hyperstack-org / hyperstack-org/hyperstack

hyper-spec not working with webpack setup

未关闭
#145 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
bug
主要语言
JavaScript
星标
538
派生
41
PR 合并指标
30 天内没有已合并 PR

描述

looks like if webpack is in use then the standard layout looks like:

```erb
<%= javascript_pack_tag 'hyperstack' %>
<%= javascript_include_tag 'application', 'data-turbolinks-track': 'reload' %>
```

but hyper-spec has not been trained to do this, and only includes the application tag by default.

Workaround for now is to add a `client_options layout: 'application'` in a before(:all) block in your spec helper. This will force hyper-spec to just use the application layout instead of building its own.

Solution is probably to add a webpack option that works like the hyper-spec javascript option, and then to default this value to `hyperstack`...

@barriehadfield can you weigh in... would we ever have a whole list of webpacks, or is it always going to be `hyperstack` for a standard setup?

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。