hyperlight-dev / hyperlight-dev/hyperlight
maintainer PRs still require manual approval of workflow
- Lingua principale
- Rust
- Stelle
- 4.7k
- Fork
- 208
- Merge medio
- 1g 7h
- PR unite (30g)
- 47
Descrizione
Copilot reviews trigger the [`Ready-for-review (collect)` workflow](https://github.com/hyperlight-dev/hyperlight/blob/main/.github/workflows/ready-for-review-label.yml#L14-L18). GitHub treats Copilot as an external actor, so our `all_external_contributors` policy requires approval.
This leaves an approval warning on maintainer PRs. [PR #1723](https://github.com/hyperlight-dev/hyperlight/pull/1723) and [run 31618809389](https://github.com/hyperlight-dev/hyperlight/actions/runs/31618809389) show the issue.
Job conditions do not help because approval happens first. Or we can remove copilot reviews entirely
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Start with .github/workflows/ready-for-review-label.yml, the all_external_contributors policy, PR #1723, and run 31618809389 to confirm where approval is required. Decide whether maintainer Copilot reviews should be exempted or removed, then verify the chosen behavior no longer leaves an approval warning on maintainer PRs.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- github-actions
- Ambito
- ci-cd
- Tipo di issue
- Bug
- Difficoltà
- 3/5
- Tempo stimato
- 1-2 giorni
- Stato di attività
- Tranquilla
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 52/100