hyperlight-dev / hyperlight-dev/hyperlight

maintainer PRs still require manual approval of workflow

Abierto
#1,731 1 comentario 0 reacciones 0 asignados Ver en GitHub
lifecycle/needs-review
Lenguaje dominante
Rust
Estrellas
4.7k
Forks
208
Merge medio
1 d 7 h
PR fusionados (30 d)
48

Descripción

Copilot reviews trigger the [`Ready-for-review (collect)` workflow](https://github.com/hyperlight-dev/hyperlight/blob/main/.github/workflows/ready-for-review-label.yml#L14-L18). GitHub treats Copilot as an external actor, so our `all_external_contributors` policy requires approval.

This leaves an approval warning on maintainer PRs. [PR #1723](https://github.com/hyperlight-dev/hyperlight/pull/1723) and [run 31618809389](https://github.com/hyperlight-dev/hyperlight/actions/runs/31618809389) show the issue.

Image

Job conditions do not help because approval happens first. Or we can remove copilot reviews entirely

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start with .github/workflows/ready-for-review-label.yml, the all_external_contributors policy, PR #1723, and run 31618809389 to confirm where approval is required. Decide whether maintainer Copilot reviews should be exempted or removed, then verify the chosen behavior no longer leaves an approval warning on maintainer PRs.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github-actions
Área
ci-cd
Tipo de issue
Error
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
52/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.