hyperlight-dev / hyperlight-dev/hyperlight
Rethink `dbg_mem_access_fn`
- Langage dominant
- Rust
- Étoiles
- 4.7k
- Forks
- 208
- Merge moyen
- 1 j 7 h
- PR mergées (30 j)
- 48
Description
It seems like the existing behaviour is perhaps not quite correct, because now that the actual mappings for the snapshot/scratch region can easily change (and do on most snapshot restores!), `dbg_mem_access_fn` will end up pointing at the wrong memory. Furthermore, the snapshot code has a very similar (although slightly different) need to access memory, and it might be nice if we could factor out at least the logic for determining which memory (snapshot, scratch, mapped region) a given GVA maps to.
See also comments introduced [here](https://github.com/hyperlight-dev/hyperlight/pull/1205/changes#diff-1cba2375519df897e902f330b1658cca5e7d51bd04e51e13df334e1dfc875bda) and [here](https://github.com/hyperlight-dev/hyperlight/pull/1205/changes#diff-8648026b1ccaa4a6c65f867f975a42d1db6ae78c3968e166d246ce03175c30afR938).
Guide de contribution
Ouvrir le guide de contribution
Évaluation
Cette issue n'a pas encore été évaluée.