hyperlight-dev / hyperlight-dev/hyperlight

Rethink `dbg_mem_access_fn`

Open
#1,208 1 comment 0 reactions 0 assignees View on GitHub
area/API lifecycle/confirmed
Dominant language
Rust
Stars
4.7k
Forks
208
Avg merge
1d 7h
Merged PRs (30d)
47

Description

It seems like the existing behaviour is perhaps not quite correct, because now that the actual mappings for the snapshot/scratch region can easily change (and do on most snapshot restores!), `dbg_mem_access_fn` will end up pointing at the wrong memory. Furthermore, the snapshot code has a very similar (although slightly different) need to access memory, and it might be nice if we could factor out at least the logic for determining which memory (snapshot, scratch, mapped region) a given GVA maps to.

See also comments introduced [here](https://github.com/hyperlight-dev/hyperlight/pull/1205/changes#diff-1cba2375519df897e902f330b1658cca5e7d51bd04e51e13df334e1dfc875bda) and [here](https://github.com/hyperlight-dev/hyperlight/pull/1205/changes#diff-8648026b1ccaa4a6c65f867f975a42d1db6ae78c3968e166d246ce03175c30afR938).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.