humanmade / humanmade/react-wp-scripts

Remove react/react-dom/etc from externals

未关闭
#68 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
enhancement
主要语言
JavaScript
星标
232
派生
30
PR 合并指标
30 天内没有已合并 PR

描述

1e26dfd2b160d4b4218efed0ac0c41f7db8f0829 configured react/react-dom/moment as externals. This removes the ability for users to control these scripts, and goes against the original purpose of react-wp-scripts (for SPAs) as it introduces a hard dependency on core's version of these scripts.

(Might be worth a setting of some sort for this?)

贡献指南

这个仓库没有索引到贡献指南

调研方向

Review commit 1e26dfd2b160d4b4218efed0ac0c41f7db8f0829 and the current externals configuration to understand how react, react-dom, and moment are handled. Done means users can control these scripts again without an unintended hard dependency on WordPress core; determine from the existing configuration whether a setting is needed.

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript, react
领域
build-system, frontend
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。