humanmade / humanmade/react-wp-scripts
Remove react/react-dom/etc from externals
- Vorherrschende Sprache
- JavaScript
- Sterne
- 232
- Forks
- 30
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
1e26dfd2b160d4b4218efed0ac0c41f7db8f0829 configured react/react-dom/moment as externals. This removes the ability for users to control these scripts, and goes against the original purpose of react-wp-scripts (for SPAs) as it introduces a hard dependency on core's version of these scripts.
(Might be worth a setting of some sort for this?)
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Rechercherichtung
Review commit 1e26dfd2b160d4b4218efed0ac0c41f7db8f0829 and the current externals configuration to understand how react, react-dom, and moment are handled. Done means users can control these scripts again without an unintended hard dependency on WordPress core; determine from the existing configuration whether a setting is needed.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- javascript, react
- Bereich
- build-system, frontend
- Issue-Typ
- Bug
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 35/100