humanmade / humanmade/react-wp-scripts

Remove react/react-dom/etc from externals

Open
#68 3 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
JavaScript
Stars
232
Forks
30
PR merge metrics
No merged PRs in 30d

Description

1e26dfd2b160d4b4218efed0ac0c41f7db8f0829 configured react/react-dom/moment as externals. This removes the ability for users to control these scripts, and goes against the original purpose of react-wp-scripts (for SPAs) as it introduces a hard dependency on core's version of these scripts.

(Might be worth a setting of some sort for this?)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.