humanmade / humanmade/react-wp-scripts

Question: Only for SPA? If used in a regular plugin, service-worker.js not loading.

未关闭
#28 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
232
派生
30
PR 合并指标
30 天内没有已合并 PR

描述

I am using this tool for a tutorial of mine which I am writing.

It is a classic WordPress plugin which loads the React App as a part of a shortcode. Everything is working fine except trying to load the service-worker.js on the root URL.

I guess that is fine when it is used as a SPA.

If you plan for this tool to be used inside themes/plugins that are not intended for SPA sites, maybe there could be setting in $defaults: https://github.com/humanmade/react-wp-scripts/blob/master/loader.php#L130 to exclude service-worker.js from loading?

If not, just close it as if it was never asked :D

Thanks for such a nice tool!

贡献指南

这个仓库没有索引到贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。