humanmade / humanmade/react-wp-scripts
Question: Only for SPA? If used in a regular plugin, service-worker.js not loading.
- Lingua principale
- JavaScript
- Stelle
- 232
- Fork
- 30
- Metriche di merge delle PR
- Nessuna PR unita negli ultimi 30g
Descrizione
I am using this tool for a tutorial of mine which I am writing.
It is a classic WordPress plugin which loads the React App as a part of a shortcode. Everything is working fine except trying to load the service-worker.js on the root URL.
I guess that is fine when it is used as a SPA.
If you plan for this tool to be used inside themes/plugins that are not intended for SPA sites, maybe there could be setting in $defaults: https://github.com/humanmade/react-wp-scripts/blob/master/loader.php#L130 to exclude service-worker.js from loading?
If not, just close it as if it was never asked :D
Thanks for such a nice tool!
Guida per i contributori
Nessuna guida per i contributori indicizzata per questo repository
Valutazione
Questa issue non è ancora stata valutata.