haskell / haskell/HTTP

Improper encoding of reserved characters

Open
#83 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Haskell
Stars
186
Forks
59
PR merge metrics
No merged PRs in 30d

Description

This was [originally](https://github.com/haskell/cabal/issues/1579) reported as a Cabal bug, but I believe it belongs here:

> The value of HTTP_PROXY has as format
> http://user:pass@host:80/
>
> In the password special characters can occur, like @ and !.
> According to wiki (http://en.wikipedia.org/wiki/Percent-escape)
> these characters must be percent-encoded, like %40 and %21.
>
> Cabal doesn't accept percent-encoded characters.
> And cabal errs on these characters (if password is a@b, Cabal doesn't look to the right site, but >probably to "b@host:80" (error message is not clear enough to be certain)

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue does not name a file or test; start by tracing how HTTP_PROXY values are parsed and reproduce a password containing percent-encoded reserved characters such as %40 and %21. Done should mean these characters are accepted and the request uses the intended host, with regression coverage for the proxy URL case.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.