hardbyte / hardbyte/python-common-expression-language
Common base class for CEL exceptions, without breaking the existing builtin mappings
- 主要語言
- Python
- 星號
- 43
- 分支
- 4
- 平均合併
- 9 小時 57 分鐘
- 30 天內合併 PR
- 14
描述
Follow-up promised when closing #23. Execution errors are mapped to the idiomatic builtin (`RuntimeError`, `TypeError`, `KeyError`, `IndexError`, `ZeroDivisionError`, `OverflowError`) and parse errors to `ValueError`, which is right for each case but means "did the rule run and fail" needs a five-clause `except`:
```python
except (RuntimeError, TypeError, KeyError, IndexError, ArithmeticError):
```
## Proposal
Add a `cel.CelError` hierarchy whose members also inherit from the builtin they replace, so nothing existing breaks:
```python
class CelError(Exception): ...
class CelParseError(CelError, ValueError): ...
class CelRuntimeError(CelError, RuntimeError): ...
class CelTypeError(CelError, TypeError): ...
class CelKeyError(CelError, KeyError): ...
class CelIndexError(CelError, IndexError): ...
class CelZeroDivisionError(CelError, ZeroDivisionError): ...
class CelOverflowError(CelError, OverflowError): ...
```
`except TypeError` keeps working; `except cel.CelError` catches everything CEL raised; `except cel.CelParseError` separates a bad rule from a failed check.
## Implementation notes
PyO3's `create_exception!` only takes a single base, so define the classes in a small `python/cel/exceptions.py` and have `map_execution_error_to_python` look them up from the module once (a `GILOnceCell>` per class) and raise with `PyErr::from_type`. Add them to `cel.pyi` and to the error-handling how-to, whose current table becomes the mapping between the two hierarchies.
貢獻指南
研究方向
Start by inspecting python/cel/exceptions.py, map_execution_error_to_python, cel.pyi, and the error-handling how-to. Trace the existing execution and parse error mappings, then verify that the new hierarchy preserves builtin exception handling, supports catching cel.CelError, and is documented in the stub and how-to table.
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python, rust
- 領域
- backend-api-design, documentation
- Issue 類型
- 功能
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 活躍
- 描述清晰度
- 描述清楚
- 新手友好度
- 48/100