hardbyte / hardbyte/python-common-expression-language

Common base class for CEL exceptions, without breaking the existing builtin mappings

Offen
#49 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
enhancement
Vorherrschende Sprache
Python
Sterne
43
Forks
4
Ø Merge
9 Std. 57 Min.
Gemergte PRs (30 T.)
14

Beschreibung

Follow-up promised when closing #23. Execution errors are mapped to the idiomatic builtin (`RuntimeError`, `TypeError`, `KeyError`, `IndexError`, `ZeroDivisionError`, `OverflowError`) and parse errors to `ValueError`, which is right for each case but means "did the rule run and fail" needs a five-clause `except`:

```python
except (RuntimeError, TypeError, KeyError, IndexError, ArithmeticError):
```

## Proposal

Add a `cel.CelError` hierarchy whose members also inherit from the builtin they replace, so nothing existing breaks:

```python
class CelError(Exception): ...
class CelParseError(CelError, ValueError): ...
class CelRuntimeError(CelError, RuntimeError): ...
class CelTypeError(CelError, TypeError): ...
class CelKeyError(CelError, KeyError): ...
class CelIndexError(CelError, IndexError): ...
class CelZeroDivisionError(CelError, ZeroDivisionError): ...
class CelOverflowError(CelError, OverflowError): ...
```

`except TypeError` keeps working; `except cel.CelError` catches everything CEL raised; `except cel.CelParseError` separates a bad rule from a failed check.

## Implementation notes

PyO3's `create_exception!` only takes a single base, so define the classes in a small `python/cel/exceptions.py` and have `map_execution_error_to_python` look them up from the module once (a `GILOnceCell>` per class) and raise with `PyErr::from_type`. Add them to `cel.pyi` and to the error-handling how-to, whose current table becomes the mapping between the two hierarchies.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start by inspecting python/cel/exceptions.py, map_execution_error_to_python, cel.pyi, and the error-handling how-to. Trace the existing execution and parse error mappings, then verify that the new hierarchy preserves builtin exception handling, supports catching cel.CelError, and is documented in the stub and how-to table.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
python, rust
Bereich
backend-api-design, documentation
Issue-Typ
Feature
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Aktiv
Klarheit
Klar beschrieben
Anfängerfreundlichkeit
48/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.