handzlikchris / handzlikchris/FastScriptReload
Generic class parameter isn't updated to patched version
- Vorherrschende Sprache
- C#
- Sterne
- 2.2k
- Forks
- 167
- PR-Merge-Kennzahlen
- Keine gemergten PRs in 30 T.
Beschreibung
This
```csharp
public class ZoomEvent : MouseEventBase {
public Vector2 Delta { get; private set; }
public static ZoomEvent GetPooled(Vector2 delta) {
var pooled = MouseEventBase.GetPooled();
pooled.Delta = delta * WheelEvent.scrollDeltaPerTick;
// ...
return pooled;
}
}
```
produces following
```csharp
public class ZoomEvent__Patched_: MouseEventBase { // I guess there should be MouseEventBase?
public Vector2 Delta { get; private set; }
public static ZoomEvent__Patched_ GetPooled(Vector2 delta) {
var pooled = MouseEventBase.GetPooled(); // And here too?
pooled.Delta = delta * WheelEvent.scrollDeltaPerTick;
// ...
return pooled;
}
}
```
Beitragsleitfaden
Für dieses Repository ist kein Beitragsleitfaden indexiert
Rechercherichtung
Start by locating the code that rewrites generic type names and references when producing patched C# classes. Reproduce the ZoomEvent and MouseEventBase example from the issue, then inspect the generated class and GetPooled call. Done means the patched type parameters and related references consistently use the patched class name.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- csharp, unity
- Bereich
- devtools, game-dev
- Issue-Typ
- Bug
- Schwierigkeit
- 4/5
- Geschätzter Aufwand
- 3-5 Tage
- Aktivitätsstatus
- Veraltet
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 32/100