handzlikchris / handzlikchris/FastScriptReload

Added fields not working with Unity editors drawn without IMGUI (ie 2022.3)

Aperta
#108 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
bug
Lingua principale
C#
Stelle
2.2k
Fork
167
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

On recent Unity versions (tested with v2022.3.10f1 on my side), Unity is no longer drawing default inspector with IMGUI (but with Visual Elements). Making the added fields feature no longer working.

This can be verified by enabling "Use IMGUI Default Inspector" in the Project Settings > Editor.
When enabled added fields feature is working again.
When disabled, as Unity is no longer calling DrawDefaultInspector, the harmony patch is no longer effective, and RenderNewlyAddedFields is no longer called.

I guess an additional patch would be needed in NewFieldsRendererDefaultEditorPatch constructor to add compatibility with the new way Unity is drawing inspectors. Probably by adding a patch to CreateInspectorGUI, where you could add the creation of a new [IMGUIContainer](https://docs.unity3d.com/ScriptReference/UIElements.IMGUIContainer-ctor.html), which would call RenderNewlyAddedFields (onGUIHandler).

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Direzione di ricerca

Start with the NewFieldsRendererDefaultEditorPatch constructor and trace how DrawDefaultInspector currently leads to RenderNewlyAddedFields. Reproduce the behavior in Unity 2022.3 with Use IMGUI Default Inspector enabled and disabled, then inspect CreateInspectorGUI and IMGUIContainer integration. Done means added fields render when Unity uses the Visual Elements inspector, while existing IMGUI behavior remains working.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
csharp, unity
Ambito
game-dev, tooling
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.