grpc / grpc/grpc-java

ClientXdsClient throws away exception information

Aperta
#7,977 0 commenti 0 reazioni 1 assegnatario Rivendicata da @sergiitk Vedi su GitHub
Lingua principale
Java
Stelle
12.1k
Fork
4k
Merge medio
2g 17h
PR unite (30g)
37

Descrizione

While ClientXdsClient commonly uses approach like StructOrError to avoid creating exceptions, there are still exceptions that need to be caught. This is most frequently InvalidProtocolBufferException, but can also entail IllegalArgumentException, PatternSyntaxException, and maybe others.

Unfortunately, the fully causal chain and stack trace is being completely thrown away for these exceptions. At the _very least_ they should be logged at FINE or lower level. In cases that produce a Status, the cause would ideally be included as the Status cause. However, XdsLogger's API currently doesn't allow logging exceptions and StructOrError only supports simple strings.

CC @voidzcy, @dapengzhang0, @sergiitk

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.