grpc / grpc/grpc-java

ClientXdsClient throws away exception information

Ouverte
#7,977 0 commentaires 0 réactions 1 personne assignée Réclamée par @sergiitk Voir sur GitHub
Langage dominant
Java
Étoiles
12.1k
Forks
4k
Merge moyen
2 j 17 h
PR mergées (30 j)
37

Description

While ClientXdsClient commonly uses approach like StructOrError to avoid creating exceptions, there are still exceptions that need to be caught. This is most frequently InvalidProtocolBufferException, but can also entail IllegalArgumentException, PatternSyntaxException, and maybe others.

Unfortunately, the fully causal chain and stack trace is being completely thrown away for these exceptions. At the _very least_ they should be logged at FINE or lower level. In cases that produce a Status, the cause would ideally be included as the Status cause. However, XdsLogger's API currently doesn't allow logging exceptions and StructOrError only supports simple strings.

CC @voidzcy, @dapengzhang0, @sergiitk

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.