grpc / grpc/grpc-java

Clarify NameResolver.Listener behavior/expectations when the servers remain the same

オープン
#6,524 コメント 9 件 リアクション 0 件 担当者 1 名 @ejona86 が担当を希望しています GitHub で見る
docs enhancement
主要言語
Java
スター
12.1k
フォーク
4k
平均マージ
2日 17時間
マージ済み PR(30日)
37

説明

### Is your feature request related to a problem?

I have a (Spring) discovery service based `NameResolver` which sends regular updates/ticks to the application, however it does not contain details which service name might have changed. So I have to check them for updates frequently, even if only one is service updated.

Should I verify whether the server addresses remained the same before invoking `onAddresses`/ `onResult`? How expensive is calling the method with the same servers over and over again? Does it trigger new connections to be made?

### Describe the solution you'd like

Javadocs that explain what the listener will/are supposed to do if they get (partially) the same addresses.

Either:

````
The listener will create a diff with any previous server list and prepare (close) connections for the new (old) servers
````

Or:

````
`NameResolver`s are discouraged from calling this method if the result hasn't changed from before.
````

### Additional context

Ref #1770
Related #6523

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。