grpc / grpc/grpc-java

Recommended IntelliJ code style settings are out of date

Aperta
#617 5 commenti 0 reazioni 0 assegnatari Vedi su GitHub
help wanted
Lingua principale
Java
Stelle
12.1k
Fork
4k
Merge medio
2g 17h
PR unite (30g)
37

Descrizione

I downloaded and imported the GoogleStyle code style settings xml, as recommended in Contributing.md. It doesn't seem like this project and its checkstyle are actually conforming to those style settings (which is fine, I like the prevailing gRPC style better!) A few things in particular keep coming up:
- Import order: GoogleStyle has static imports at the bottom, doesn't separate grpc imports. This is configured in `Code Style > Java > Imports > Import Layout`.
- Method argument wrapping: GoogleStyle has method call arguments and declaration parameters on the next line aligned to the opening paren. This is configured in `Code Style > Java > Wrapping and Braces > Method declaration parameters > Align when multiline`, as well as the same option under `Method call arguments`.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.