grpc / grpc/grpc-java

Recommended IntelliJ code style settings are out of date

Abierto
#617 5 comentarios 0 reacciones 0 asignados Ver en GitHub
help wanted
Lenguaje dominante
Java
Estrellas
12.1k
Forks
4k
Merge medio
2 d 17 h
PR fusionados (30 d)
37

Descripción

I downloaded and imported the GoogleStyle code style settings xml, as recommended in Contributing.md. It doesn't seem like this project and its checkstyle are actually conforming to those style settings (which is fine, I like the prevailing gRPC style better!) A few things in particular keep coming up:
- Import order: GoogleStyle has static imports at the bottom, doesn't separate grpc imports. This is configured in `Code Style > Java > Imports > Import Layout`.
- Method argument wrapping: GoogleStyle has method call arguments and declaration parameters on the next line aligned to the opening paren. This is configured in `Code Style > Java > Wrapping and Braces > Method declaration parameters > Align when multiline`, as well as the same option under `Method call arguments`.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start with Contributing.md and the recommended GoogleStyle code style settings XML, then compare its IntelliJ import layout and method wrapping options with the project's checkstyle and prevailing gRPC style. Done means the recommendation and settings consistently describe the intended import order and method argument or parameter wrapping.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
java
Área
developer-experience, tooling
Tipo de issue
Documentación
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.