graykode / graykode/nlp-tutorial

Question about tensor.view operation in Bi-LSTM(Attention)

オープン
#38 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る
主要言語
Jupyter Notebook
スター
14.9k
フォーク
3.9k
PR マージ指標
30日以内にマージされた PR はありません

説明

https://github.com/graykode/nlp-tutorial/blob/cb4881ebf6683dc6970c53a2cf50d5fd01edf118/4-3.Bi-LSTM(Attention)/Bi-LSTM(Attention)-Torch.py#L50

Hi, this repo is awesome, but there might be something wrong in the code above. According to the comment above, this snippet intends to change a tensor from shape `[num_layers(=1) * num_directions(=2), batch_size, n_hidden]` to shape `[batch_size, n_hidden * num_directions(=2), 1(=n_layer)]`, i.e. to concatenate the 2 hidden vector from different direction for every data example in a batch(By saying "data example", I mean a batch has `batch_size` examples). But I think the code above will mess up the data examples in a batch and lead to unexpected result.

For example, we can use IPython to check the effect of the snippet above.

```py
# create a tensor with shape [num_layers(=1) * num_directions(=2), batch_size, n_hidden]
In [10]: a=torch.arange(2*3*5).reshape(2,3,5)

In [11]: a
Out[11]:
tensor([[[ 0, 1, 2, 3, 4],
[ 5, 6, 7, 8, 9],
[10, 11, 12, 13, 14]],

[[15, 16, 17, 18, 19],
[20, 21, 22, 23, 24],
[25, 26, 27, 28, 29]]])

In [12]: a.view(-1,10,1)
Out[12]:
tensor([[[ 0],
[ 1],
[ 2],
[ 3],
[ 4],
[ 5],
[ 6],
[ 7],
[ 8],
[ 9]],

[[10],
[11],
[12],
[13],
[14],
[15],
[16],
[17],
[18],
[19]],

[[20],
[21],
[22],
[23],
[24],
[25],
[26],
[27],
[28],
[29]]])


```

As you can see, we create a tensor with batch_size=3 and n_hidden=5, e.g `[ 0, 1, 2, 3, 4]` and `[15, 16, 17, 18, 19]` belong to the same data example in the batch, but they are from different directions, so what we want is to concatenate them in the resulting tensor. But what the code really does is to concatenate `[ 0, 1, 2, 3, 4]` and `[ 5, 6, 7, 8, 9]`, which are from **different data examples in a batch**.

I think it can be fixed by changing the line of code to `hidden=torch.cat(final_state[0],final_state[1]],1).view(-1,10,1)`

The effect of the new code can be shown as follows:

```py
In [13]: torch.cat([a[0],a[1]],1).view(-1,10,1)
Out[13]:
tensor([[[ 0],
[ 1],
[ 2],
[ 3],
[ 4],
[15],
[16],
[17],
[18],
[19]],

[[ 5],
[ 6],
[ 7],
[ 8],
[ 9],
[20],
[21],
[22],
[23],
[24]],

[[10],
[11],
[12],
[13],
[14],
[25],
[26],
[27],
[28],
[29]]])

```

コントリビューションガイド

コントリビューションガイドを開く

調査の方向性

Inspect 4-3.Bi-LSTM(Attention)/Bi-LSTM(Attention)-Torch.py at line 50 and compare the reshape with the documented hidden-state shape. Use the tensor example in the issue to verify that each batch example combines its two directional vectors; the issue is done when the resulting tensor preserves those pairings.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
python, pytorch
領域
machine-learning
issue の種類
バグ
難易度
2/5
見積もり時間
1〜3時間
活発さ
停滞
明瞭さ
明確に書かれている
初心者へのやさしさ
52/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。