graykode / graykode/nlp-tutorial

A questions about decoder in seq2seq-torch

Open
#36 1 comment 4 reactions 0 assignees View on GitHub
Dominant language
Jupyter Notebook
Stars
14.9k
Forks
3.9k
PR merge metrics
No merged PRs in 30d

Description

https://github.com/graykode/nlp-tutorial/blob/6e171b914ed28eb04dc9176916a99e9a996a7951/4-1.Seq2Seq/Seq2Seq-Torch.py#L92
Hi,I‘m a nlp rookie.I want to ask you a question.I read the seq2seq's paper,which use t-1 output as the t input in decoder. Your code in this line use 'SPPPPP' as the decoder input.So,is this way harm to the result?
If you see this issues, please answer me in your free time.
Although my english is poor, I still want to express my gratitude to you.
![image](https://user-images.githubusercontent.com/18107702/62860488-e933a080-bd32-11e9-9106-874d2c07dc5b.png)

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.