graphql-python / graphql-python/graphql-ws

GeventSubscriptionServer ignore schema validation errors

Ouverte
#52 0 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Python
Étoiles
270
Forks
85
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

* GraphQL AioWS version: 0.3.1
* Python version: Python 3.8.5
* Operating System: Debian

### Description

GeventSubscriptionServer ignore any schema validation errors.
I use Altair GraphQL client. When I send subscription request with schema text errors (for example: wrong field name), this error is covered by GeventSubscriptionServer and just raise "A subscription must return an observable"

I think problem in following lines in `gevent.py`, line 74:75:

`
assert isinstance(execution_result, Observable), \
"A subscription must return an observable"
`

There's check only for Observable, but in case of schema error its return ExecutionResult object with errors, then assert is failed, another error is raising

### What I Did

Any subscription query with any schema error

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.