graphql-python / graphql-python/graphql-ws

GeventSubscriptionServer ignore schema validation errors

Abierto
#52 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
Python
Estrellas
270
Forks
85
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

* GraphQL AioWS version: 0.3.1
* Python version: Python 3.8.5
* Operating System: Debian

### Description

GeventSubscriptionServer ignore any schema validation errors.
I use Altair GraphQL client. When I send subscription request with schema text errors (for example: wrong field name), this error is covered by GeventSubscriptionServer and just raise "A subscription must return an observable"

I think problem in following lines in `gevent.py`, line 74:75:

`
assert isinstance(execution_result, Observable), \
"A subscription must return an observable"
`

There's check only for Observable, but in case of schema error its return ExecutionResult object with errors, then assert is failed, another error is raising

### What I Did

Any subscription query with any schema error

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.