graphql-python / graphql-python/graphene

Remove promise import from graphene.test.Client

オープン
#1,260 コメント 6 件 リアクション 2 件 担当者 0 名 GitHub で見る
🐛 bug
主要言語
Python
スター
8.2k
フォーク
818
PR マージ指標
30日以内にマージされた PR はありません

説明

* **What is the current behavior?**
Installing `graphene==v3.0.0b5` does not auto install `promise` which is required when writing tests using `graphene.test.Client` (see here)

```/tmp/graphene master
venv 福 pip install graphene==3.0.0b5
Collecting graphene==3.0.0b5
Using cached graphene-3.0b5-py2.py3-none-any.whl (106 kB)
Collecting aniso8601<9,>=8
Using cached aniso8601-8.0.0-py2.py3-none-any.whl (43 kB)
Collecting graphql-relay<4,>=3.0
Using cached graphql_relay-3.0.0-py3-none-any.whl (15 kB)
Collecting graphql-core<4,>=3.1.2
Using cached graphql_core-3.1.2-py3-none-any.whl (183 kB)
Installing collected packages: aniso8601, graphql-core, graphql-relay, graphene
Successfully installed aniso8601-8.0.0 graphene-3.0b5 graphql-core-3.1.2 graphql-relay-3.0.0

/tmp/graphene master
venv 福 pip freeze
aniso8601==8.0.0
graphene==3.0b5
graphql-core==3.1.2
graphql-relay==3.0.0
```

* **What is the expected behavior?**
The installation procedure installs `promise` as it's currently being done with the version `v2.1.8`
```/tmp/graphene master
venv 福 pip install graphene
Collecting graphene
Using cached graphene-2.1.8-py2.py3-none-any.whl (107 kB)
Collecting graphql-relay<3,>=2
Using cached graphql_relay-2.0.1-py3-none-any.whl (20 kB)
Collecting graphql-core<3,>=2.1
Using cached graphql_core-2.3.2-py2.py3-none-any.whl (252 kB)
Collecting six<2,>=1.10.0
Using cached six-1.15.0-py2.py3-none-any.whl (10 kB)
Collecting aniso8601<=7,>=3
Using cached aniso8601-7.0.0-py2.py3-none-any.whl (42 kB)
Processing /home/valz/.cache/pip/wheels/54/aa/01/724885182f93150035a2a91bce34a12877e8067a97baaf5dc8/promise-2.3-py3-none-any.whl
Collecting rx<2,>=1.6
Using cached Rx-1.6.1-py2.py3-none-any.whl (179 kB)
Installing collected packages: rx, six, promise, graphql-core, graphql-relay, aniso8601, graphene
Successfully installed aniso8601-7.0.0 graphene-2.1.8 graphql-core-2.3.2 graphql-relay-2.0.1 promise-2.3 rx-1.6.1 six-1.15.0

/tmp/graphene master
venv 福 pip freeze
aniso8601==7.0.0
graphene==2.1.8
graphql-core==2.3.2
graphql-relay==2.0.1
promise==2.3
Rx==1.6.1
six==1.15.0
```

* **What is the motivation / use case for changing the behavior?**
I wrote tests using the test client, and while everything worked fine on my laptop at first (I may have installed graphene v2 before the v3), our CI freshly installed from v3 and failed to run tests because of this missing package, which made me realize there seems to be a packaging issue on your side (we use poetry with `poetry add graphene --allow-prereleases` - but pip failed to install the expected dep as well)

* **Please tell us about your environment:**
- Version: v3.0.0b5
- Platform: ArchLinux x86_64 Linux 5.8.1-arch1-1

* **Other information** (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow)

Actual stacktrace from my failing CI job
```
ImportError while importing test module '/builds/redacted/redacted/redacted/tests/test_graphql.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
redacted/tests/test_graphql.py:6: in
from graphene.test import Client
/var/www/.cache/pypoetry/virtualenvs/redacted-674zaAdZ-py3.8/lib/python3.8/site-packages/graphene/test/__init__.py:1: in
from promise import Promise, is_thenable
E ModuleNotFoundError: No module named 'promise'
```

コントリビューションガイド

このリポジトリのコントリビューションガイドは索引されていません

調査の方向性

traceback に失敗している promise の import が示されている graphene/test/__init__.py から始め、次に graphene パッケージのビルドに使用される依存関係メタデータを調べます。新しい環境で graphene v3.0.0b5 をインストールし、graphene.test.Client を import して動作を確認します。報告された ModuleNotFoundError なしでクライアントの import が機能すれば完了です。

索引モデルが issue の本文から書いたものです。

評価

技術スタック
python
領域
api, backend
issue の種類
バグ
難易度
2/5
見積もり時間
1〜3時間
活発さ
停滞
明瞭さ
おおむね明確
初心者へのやさしさ
35/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。