gr2m / gr2m/github-openapi-graphql-query

GraphQL result to query gives a wrong result for a required parameters of `Create Check Run`

Ouverte
#11 3 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
JavaScript
Étoiles
7
Forks
3
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

# Context
Octokit documentation on how to create a Check Run is missing 2 required properties: `name` and `head_sha`. Detailed explanation in Octokit: https://github.com/octokit/plugin-rest-endpoint-methods.js/issues/441

# Where could be the problem?
GitHub's Open API information (the dereferenced one) and Octokit's API dereferenced look good. `name` and `head_sha` are there and are marked as `required`.

Instead of appearing those properties, the result of the query provides a property with `*` as key.

In a quick look of the code I see suspicious the following lines:
https://github.com/gr2m/github-openapi-graphql-query/blob/405891d8cd001f2c126174e6f1bf5f9847213a54/lib/schema-to-parameters.js#L3

and

https://github.com/gr2m/github-openapi-graphql-query/blob/405891d8cd001f2c126174e6f1bf5f9847213a54/lib/schema-to-parameters.js#L56

But I'm not sure if that could be the issue. Any ideas to start digging a bit @gr2m ? :)

Guide de contribution

Aucun guide de contribution indexé pour ce dépôt

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.