gr2m / gr2m/github-openapi-graphql-query

GraphQL result to query gives a wrong result for a required parameters of `Create Check Run`

Offen
#11 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
JavaScript
Sterne
7
Forks
3
PR-Merge-Kennzahlen
Keine gemergten PRs in 30 T.

Beschreibung

# Context
Octokit documentation on how to create a Check Run is missing 2 required properties: `name` and `head_sha`. Detailed explanation in Octokit: https://github.com/octokit/plugin-rest-endpoint-methods.js/issues/441

# Where could be the problem?
GitHub's Open API information (the dereferenced one) and Octokit's API dereferenced look good. `name` and `head_sha` are there and are marked as `required`.

Instead of appearing those properties, the result of the query provides a property with `*` as key.

In a quick look of the code I see suspicious the following lines:
https://github.com/gr2m/github-openapi-graphql-query/blob/405891d8cd001f2c126174e6f1bf5f9847213a54/lib/schema-to-parameters.js#L3

and

https://github.com/gr2m/github-openapi-graphql-query/blob/405891d8cd001f2c126174e6f1bf5f9847213a54/lib/schema-to-parameters.js#L56

But I'm not sure if that could be the issue. Any ideas to start digging a bit @gr2m ? :)

Beitragsleitfaden

Für dieses Repository ist kein Beitragsleitfaden indexiert

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.