googleapis / googleapis/python-aiplatform
Inconsistent file type check in google/cloud/aiplatform/utils/gcs_utils.py and vertexai/evaluation/utils.py
- Lingua principale
- Python
- Stelle
- 905
- Fork
- 465
- Merge medio
- 1g 13h
- PR unite (30g)
- 44
Descrizione
Prior to the function call [_upload_pandas_df_to_gcs](https://github.com/googleapis/python-aiplatform/blob/86fc215cb854c006a0836a6e8f98e6d40c191fee/vertexai/evaluation/utils.py#L265) in the Evaluation module, there is a [validation logic](https://github.com/googleapis/python-aiplatform/blob/86fc215cb854c006a0836a6e8f98e6d40c191fee/vertexai/evaluation/utils.py#L263) to check whether the file type is `csv`. However, within the [_upload_pandas_df_to_gcs](https://github.com/googleapis/python-aiplatform/blob/86fc215cb854c006a0836a6e8f98e6d40c191fee/google/cloud/aiplatform/utils/gcs_utils.py#L351) function implementation, `jsonl` is the only supported file type.
At least one of the types (CSV or JSONL) should be supported across both implementations.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.