googleapis / googleapis/python-aiplatform
Inconsistent file type check in google/cloud/aiplatform/utils/gcs_utils.py and vertexai/evaluation/utils.py
- Lenguaje dominante
- Python
- Estrellas
- 905
- Forks
- 465
- Merge medio
- 1 d 13 h
- PR fusionados (30 d)
- 44
Descripción
Prior to the function call [_upload_pandas_df_to_gcs](https://github.com/googleapis/python-aiplatform/blob/86fc215cb854c006a0836a6e8f98e6d40c191fee/vertexai/evaluation/utils.py#L265) in the Evaluation module, there is a [validation logic](https://github.com/googleapis/python-aiplatform/blob/86fc215cb854c006a0836a6e8f98e6d40c191fee/vertexai/evaluation/utils.py#L263) to check whether the file type is `csv`. However, within the [_upload_pandas_df_to_gcs](https://github.com/googleapis/python-aiplatform/blob/86fc215cb854c006a0836a6e8f98e6d40c191fee/google/cloud/aiplatform/utils/gcs_utils.py#L351) function implementation, `jsonl` is the only supported file type.
At least one of the types (CSV or JSONL) should be supported across both implementations.
Guía de contribución
Evaluación
Este issue todavía no se ha evaluado.