googleapis / googleapis/python-aiplatform

Naming is confusing: find_neighbors

未關閉
#2,139 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
api: vertex-ai type: feature request
主要語言
Python
星號
905
分支
465
平均合併
1 天 13 小時
30 天內合併 PR
44

描述

https://github.com/googleapis/python-aiplatform/blob/e3a87f04abf013341fe4f655b96405e27228ffdb/google/cloud/aiplatform/matching_engine/matching_engine_index_endpoint.py#L952

There is already a match method (I wrote this integration around a year ago). As I understand, `find_neighbors` is the public version of the match method.

This is quite confusing. Consider:
1. Combining find_neighbors into the match method
2. Calling find_neighbors `match_public` to show that they are related.

貢獻指南

開啟貢獻指南

研究方向

Start with google/cloud/aiplatform/matching_engine/matching_engine_index_endpoint.py around line 952 and compare the public find_neighbors method with match. Review how each name is exposed and referenced, then determine which naming approach resolves the reported confusion. Done means the relationship between the methods is unambiguous.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
python
領域
machine-learning
Issue 類型
重構
難度
5/5
預估耗時
一週以上
活躍度
停滯
描述清晰度
基本清楚
新手友好度
30/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。