googleapis / googleapis/python-aiplatform

Naming is confusing: find_neighbors

Aperta
#2,139 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
api: vertex-ai type: feature request
Lingua principale
Python
Stelle
905
Fork
465
Merge medio
1g 13h
PR unite (30g)
44

Descrizione

https://github.com/googleapis/python-aiplatform/blob/e3a87f04abf013341fe4f655b96405e27228ffdb/google/cloud/aiplatform/matching_engine/matching_engine_index_endpoint.py#L952

There is already a match method (I wrote this integration around a year ago). As I understand, `find_neighbors` is the public version of the match method.

This is quite confusing. Consider:
1. Combining find_neighbors into the match method
2. Calling find_neighbors `match_public` to show that they are related.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.