googleapis / googleapis/python-aiplatform

Naming is confusing: find_neighbors

Open
#2,139 1 comment 0 reactions 0 assignees View on GitHub
api: vertex-ai type: feature request
Dominant language
Python
Stars
905
Forks
465
Avg merge
1d 13h
Merged PRs (30d)
44

Description

https://github.com/googleapis/python-aiplatform/blob/e3a87f04abf013341fe4f655b96405e27228ffdb/google/cloud/aiplatform/matching_engine/matching_engine_index_endpoint.py#L952

There is already a match method (I wrote this integration around a year ago). As I understand, `find_neighbors` is the public version of the match method.

This is quite confusing. Consider:
1. Combining find_neighbors into the match method
2. Calling find_neighbors `match_public` to show that they are related.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.