googleapis / googleapis/java-bigtable-hbase

Add channel latency to veneer

Aperta
#2,971 0 commenti 0 reazioni 1 assegnatario Rivendicata da @mutianf Vedi su GitHub
api: bigtable type: feature request
Lingua principale
Java
Stelle
184
Fork
184
Merge medio
10h
PR unite (30g)
6

Descrizione

In bigtable-client-core, channel latency is reported from `ChannelPool` and each channel is assigned an ID at [channel creation time](https://github.com/googleapis/java-bigtable-hbase/blob/master/bigtable-client-core-parent/bigtable-client-core/src/main/java/com/google/cloud/bigtable/grpc/io/ChannelPool.java#L115).

After migrating to veneer, we could migrate this metric by adding an interceptor. However, with this implementation, channel id will be updated every hour if channel priming is enabled which could lead to high cardinality. There isn't an easy way to keep the same id for each channel without making some changes in gax.

Since `channels.channel$id.rpc.latency` is a trace level metric, this will not be implemented in the alpha release. We could add it back if necessary in the future.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.