googleapis / googleapis/java-bigtable-hbase
Add channel latency to veneer
@mutianf arbeitet bereits daran.
Seit 13.5.2021.
- Vorherrschende Sprache
- Java
- Sterne
- 184
- Forks
- 184
- Ø Merge
- 10 Std.
- Gemergte PRs (30 T.)
- 6
Beschreibung
In bigtable-client-core, channel latency is reported from ChannelPool and each channel is assigned an ID at channel creation time.
After migrating to veneer, we could migrate this metric by adding an interceptor. However, with this implementation, channel id will be updated every hour if channel priming is enabled which could lead to high cardinality. There isn't an easy way to keep the same id for each channel without making some changes in gax.
Since channels.channel$id.rpc.latency is a trace level metric, this will not be implemented in the alpha release. We could add it back if necessary in the future.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Bewertung
Dieses Issue wurde noch nicht bewertet.