googleapis / googleapis/google-cloud-python

test(repo): Add a GITHUB TOKEN to the secret manager to avoid rate limits

Aperta
#17,988 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
type: feature request
Lingua principale
Python
Stelle
5.4k
Fork
1.8k
Merge medio
3g 4h
PR unite (30g)
122

Descrizione

### Determine this is the right repository

- [x] I determined this is the correct repository in which to report this feature request.

### Summary of the feature request

The ad hoc package selection process during system tests performs a check against the GitHub (GH) API for a specific label. GH limits unauthenticated checks to 60 per hour per IP address.

Right now we are not hitting that limit, but we do not have control over any other kokoro processes that share our IP address, so we should provide a means for kokoro to authenticate and get nearly unlimited API calls.

For some context regarding where this call occurs: see https://github.com/googleapis/google-cloud-python/pull/17931#discussion_r3711547080

We will need to add the key to SECRET MANAGER in the Google Cloud Console.

### Desired code experience

### Expected results

_No response_

### API client name and version

_No response_

### Use case

_No response_

### Additional context

_No response_

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start with the ad hoc package selection process in system tests and review the linked discussion in google-cloud-python#17931 to locate the GitHub API label check. Then inspect how Kokoro accesses Google Cloud Secret Manager. Done means Kokoro can authenticate those checks with a stored GitHub token and the token is added to Secret Manager.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
github, google-cloud, python
Ambito
ci-cd, cloud, devops
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
48/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.