googleapis / googleapis/google-cloud-python

test(repo): Add a GITHUB TOKEN to the secret manager to avoid rate limits

Open
#17,988 0 comments 0 reactions 0 assignees View on GitHub
type: feature request
Dominant language
Python
Stars
5.4k
Forks
1.8k
Avg merge
3d 4h
Merged PRs (30d)
122

Description

### Determine this is the right repository

- [x] I determined this is the correct repository in which to report this feature request.

### Summary of the feature request

The ad hoc package selection process during system tests performs a check against the GitHub (GH) API for a specific label. GH limits unauthenticated checks to 60 per hour per IP address.

Right now we are not hitting that limit, but we do not have control over any other kokoro processes that share our IP address, so we should provide a means for kokoro to authenticate and get nearly unlimited API calls.

For some context regarding where this call occurs: see https://github.com/googleapis/google-cloud-python/pull/17931#discussion_r3711547080

We will need to add the key to SECRET MANAGER in the Google Cloud Console.

### Desired code experience

### Expected results

_No response_

### API client name and version

_No response_

### Use case

_No response_

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the ad hoc package selection process in system tests and review the linked discussion in google-cloud-python#17931 to locate the GitHub API label check. Then inspect how Kokoro accesses Google Cloud Secret Manager. Done means Kokoro can authenticate those checks with a stored GitHub token and the token is added to Secret Manager.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, google-cloud, python
Domain
ci-cd, cloud, devops
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.