googleapis / googleapis/google-cloud-python

google-auth: Clean up test coverage and outdated docstrings for mTLS and Identity Pool

Abierto
#17,758 2 comentarios 0 reacciones 0 asignados Ver en GitHub
auth effort: low priority: p3 testing type: cleanup
Lenguaje dominante
Python
Estrellas
5.4k
Forks
1.8k
Merge medio
3 d 4 h
PR fusionados (30 d)
122

Descripción

There are a few minor gaps in test coverage and test documentation that should be cleaned up in the `google-auth` library:

- In `tests/transport/test_aio_mtls_helper.py`, the docstring and comments for `test_get_client_cert_and_key_callback_sync` reference a `TypeError` fallback that is no longer used (the code now uses `inspect.isawaitable()`).
- The `MdsMtlsAdapter.close()` method in `google/auth/compute_engine/_mtls.py` lacks test coverage.
- There are several `RefreshError` exception paths in `google/auth/identity_pool.py` (specifically around leaf certificate retrieval and parsing) that are currently missing test coverage.

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Start with tests/transport/test_aio_mtls_helper.py and update the docstring and comments for test_get_client_cert_and_key_callback_sync. Then inspect google/auth/compute_engine/_mtls.py and google/auth/identity_pool.py alongside their existing tests, covering MdsMtlsAdapter.close() and the noted RefreshError paths. Run the affected tests and confirm the outdated TypeError references are removed and the missing paths are covered.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
testing
Tipo de issue
Refactorización
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Activo
Claridad
Bastante claro
Aptitud para principiantes
74/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.