googleapis / googleapis/google-cloud-python

add universe-domain tests

未关闭
#16,330 1 条评论 0 个 reaction 已指派 2 人 已被 @ohmayr 认领 在 GitHub 查看
priority: p1 type: cleanup
主要语言
Python
星标
5.4k
派生
1.8k
平均合并
3 天 4 小时
30 天内合并 PR
122

描述

In googleapis/gapic-generator-python#1898 I made a few suggestions for improving test coverage of the user-configured universe domain feature. In order to not delay that PR further, I am strongly leaning towards merging that as soon as the presubmits with the latest changes pass, and implementing the testing suggestions in a follow-up PR. The suggestions are:

- [ ] `TODO`s listed in `/tests/system/{conftest,test_universe_domain}.py` in googleapis/gapic-generator-python#1898
- [ ] [adding additional fixtures for configured universe possibilities](https://github.com/googleapis/gapic-generator-python/pull/1898#discussion_r1459978342)
- [ ] [adding a testcase where we provide both `cert_source` and `"never"](https://github.com/googleapis/gapic-generator-python/pull/1898#discussion_r1460004264)
- [ ] [adding a testcase where `env` is empty](https://github.com/googleapis/gapic-generator-python/pull/1898#discussion_r1460008043)
- [ ] [testing combinations of client certificate, mTLS endpoint, api_endpoint](https://github.com/googleapis/gapic-generator-python/pull/1898#discussion_r1460028365)
- [ ] [factoring out tests that don't have universe domain](https://github.com/googleapis/gapic-generator-python/pull/1898#discussion_r1460033163)

To be clear: we should make the tests as small as they can be (e.g. preferring unit tests to integration tests), and we should check whether the suggestions above have been already covered in other tests elsewhere in the codebase than where I made the comments above (I suspect in some cases that may be the case).

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。