googleapis / googleapis/google-cloud-python

add universe-domain tests

Open
#16,330 1 comment 0 reactions 2 assignees Claimed by @ohmayr View on GitHub
priority: p1 type: cleanup
Dominant language
Python
Stars
5.4k
Forks
1.8k
Avg merge
3d 4h
Merged PRs (30d)
122

Description

In googleapis/gapic-generator-python#1898 I made a few suggestions for improving test coverage of the user-configured universe domain feature. In order to not delay that PR further, I am strongly leaning towards merging that as soon as the presubmits with the latest changes pass, and implementing the testing suggestions in a follow-up PR. The suggestions are:

- [ ] `TODO`s listed in `/tests/system/{conftest,test_universe_domain}.py` in googleapis/gapic-generator-python#1898
- [ ] [adding additional fixtures for configured universe possibilities](https://github.com/googleapis/gapic-generator-python/pull/1898#discussion_r1459978342)
- [ ] [adding a testcase where we provide both `cert_source` and `"never"](https://github.com/googleapis/gapic-generator-python/pull/1898#discussion_r1460004264)
- [ ] [adding a testcase where `env` is empty](https://github.com/googleapis/gapic-generator-python/pull/1898#discussion_r1460008043)
- [ ] [testing combinations of client certificate, mTLS endpoint, api_endpoint](https://github.com/googleapis/gapic-generator-python/pull/1898#discussion_r1460028365)
- [ ] [factoring out tests that don't have universe domain](https://github.com/googleapis/gapic-generator-python/pull/1898#discussion_r1460033163)

To be clear: we should make the tests as small as they can be (e.g. preferring unit tests to integration tests), and we should check whether the suggestions above have been already covered in other tests elsewhere in the codebase than where I made the comments above (I suspect in some cases that may be the case).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.