googleapis / googleapis/google-cloud-python

pre-compute retry and timeout info for mixin methods

Aperta
#16,275 1 commento 0 reazioni 1 assegnatario Rivendicata da @ohmayr Vedi su GitHub
priority: p1 type: feature request
Lingua principale
Python
Stelle
5.4k
Fork
1.8k
Merge medio
3g 4h
PR unite (30g)
122

Descrizione

The following mixin methods implemented in the async client wrap the retry and timeout information during the method call in the following way:

```
rpc = gapic_v1.method_async.wrap_method(
self._client._transport.get_iam_policy,
default_timeout=None,
client_info=DEFAULT_CLIENT_INFO,
)
```

We should pre-compute the wrapping logic during the transport initialization, similar to what we do for other methods via `_prep_wrapped_messages`. At the very least, we need to make sure that we set the kind property (if available), in `wrap_method` to avoid a gRPC code path in an async rest call.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.