googleapis / googleapis/google-cloud-python

pre-compute retry and timeout info for mixin methods

Ouverte
#16,275 1 commentaire 0 réactions 1 personne assignée Réclamée par @ohmayr Voir sur GitHub
priority: p1 type: feature request
Langage dominant
Python
Étoiles
5.4k
Forks
1.8k
Merge moyen
3 j 4 h
PR mergées (30 j)
122

Description

The following mixin methods implemented in the async client wrap the retry and timeout information during the method call in the following way:

```
rpc = gapic_v1.method_async.wrap_method(
self._client._transport.get_iam_policy,
default_timeout=None,
client_info=DEFAULT_CLIENT_INFO,
)
```

We should pre-compute the wrapping logic during the transport initialization, similar to what we do for other methods via `_prep_wrapped_messages`. At the very least, we need to make sure that we set the kind property (if available), in `wrap_method` to avoid a gRPC code path in an async rest call.

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.