googleapis / googleapis/google-cloud-python

pre-compute retry and timeout info for mixin methods

Open
#16,275 1 comment 0 reactions 1 assignee Claimed by @ohmayr View on GitHub
priority: p1 type: feature request
Dominant language
Python
Stars
5.4k
Forks
1.8k
Avg merge
3d 4h
Merged PRs (30d)
122

Description

The following mixin methods implemented in the async client wrap the retry and timeout information during the method call in the following way:

```
rpc = gapic_v1.method_async.wrap_method(
self._client._transport.get_iam_policy,
default_timeout=None,
client_info=DEFAULT_CLIENT_INFO,
)
```

We should pre-compute the wrapping logic during the transport initialization, similar to what we do for other methods via `_prep_wrapped_messages`. At the very least, we need to make sure that we set the kind property (if available), in `wrap_method` to avoid a gRPC code path in an async rest call.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.