googleapis / googleapis/google-cloud-python

Re-using a session pool on connect() when using python-spanner with sqlalchemy

Aperta
#15,674 3 commenti 0 reazioni 1 assegnatario Rivendicata da @olavloite Vedi su GitHub
api: spanner priority: p3 type: feature request
Lingua principale
Python
Stelle
5.4k
Fork
1.8k
Merge medio
3g 4h
PR unite (30g)
122

Descrizione

**Is your feature request related to a problem? Please describe.**
When using SQL Alchemy with python-spanner-sqlalchemy, I've noticed that we're running `.bind()`, instantiating the `database` object and executing `BatchCreateSessions` for every single `connect()` call, which adds quite a bit of additional overhead before the query even executes. Main overhead that I saw was `BatchCreateSessions` when using a `PingingPool`.

**Describe the solution you'd like**
Would like the ability to pass in an existing `database` object (or have it be idempotent/detect that there's already a pool) so that the same pool and its pre-created sessions can be re-used for every SQL alchemy connection checkout, similar to how using the raw spanner client works.

**Describe alternatives you've considered**
I've tried passing a pool to the connect(), but it still recreates the sessions.

## Attempt 1
Draft PR: https://github.com/googleapis/python-spanner/pull/1493/changes

While this PR works for my specific use case (SQL Alchemy x python-spanner-sqlalchemy + PingingPool), I am not clear of the implications of allowing the re-use of the database object. Would appreciate any guidance here

PR contains a benchmarking script that tests a 7 combinations (raw spanner client, mix of values for QueuePool/StaticPool x Spanner's PingingPool):

Image

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.