googleapis / googleapis/google-cloud-python

Re-using a session pool on connect() when using python-spanner with sqlalchemy

Ouverte
#15,674 3 commentaires 0 réactions 1 personne assignée Réclamée par @olavloite Voir sur GitHub
api: spanner priority: p3 type: feature request
Langage dominant
Python
Étoiles
5.4k
Forks
1.8k
Merge moyen
2 j 23 h
PR mergées (30 j)
123

Description

**Is your feature request related to a problem? Please describe.**
When using SQL Alchemy with python-spanner-sqlalchemy, I've noticed that we're running `.bind()`, instantiating the `database` object and executing `BatchCreateSessions` for every single `connect()` call, which adds quite a bit of additional overhead before the query even executes. Main overhead that I saw was `BatchCreateSessions` when using a `PingingPool`.

**Describe the solution you'd like**
Would like the ability to pass in an existing `database` object (or have it be idempotent/detect that there's already a pool) so that the same pool and its pre-created sessions can be re-used for every SQL alchemy connection checkout, similar to how using the raw spanner client works.

**Describe alternatives you've considered**
I've tried passing a pool to the connect(), but it still recreates the sessions.

## Attempt 1
Draft PR: https://github.com/googleapis/python-spanner/pull/1493/changes

While this PR works for my specific use case (SQL Alchemy x python-spanner-sqlalchemy + PingingPool), I am not clear of the implications of allowing the re-use of the database object. Would appreciate any guidance here

PR contains a benchmarking script that tests a 7 combinations (raw spanner client, mix of values for QueuePool/StaticPool x Spanner's PingingPool):

Image

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.