googleapis / googleapis/google-cloud-python

Let Cloud Run Job use `StructuredLogHandler` instead of `ClougLoggingHandler`

Ouverte
#15,407 1 commentaire 0 réactions 1 personne assignée Assignée à @gkevinzheng Voir sur GitHub
api: logging type: feature request
Langage dominant
Python
Étoiles
5.4k
Forks
1.8k
Merge moyen
3 j 4 h
PR mergées (30 j)
122

Description

**Is your feature request related to a problem? Please describe.**
When using `Client.get_default_handler` `CloudLoggingHandler` is being used automatically for Cloud Run jobs resource. And while https://github.com/googleapis/python-logging/pull/877 fixes the missing labels we're still gonna be using background transport when simplier stdout is doing just fine.

**Describe the solution you'd like**
If we modify this check https://github.com/googleapis/python-logging/blob/62641075042a3da9bb9c059d963bad14a1586b1c/google/cloud/logging_v2/client.py#L388 and allow `_RUN_RESOURCE_TYPE` OR `_CLOUD_RUN_JOB_RESOURCE_TYPE` resource type then a structured log handler is gonna be used automatically which should be a better default.

**Describe alternatives you've considered**
Meanwhile I am using `handler = StructuredLogHandler(project_id=client.project)` instead of `handler = client.get_default_handler()` where client is `client = CloudLoggingClient()`

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.