googleapis / googleapis/google-cloud-python

Let Cloud Run Job use `StructuredLogHandler` instead of `ClougLoggingHandler`

Abierto
#15,407 1 comentario 0 reacciones 1 asignado Asignado a @gkevinzheng Ver en GitHub
api: logging type: feature request
Lenguaje dominante
Python
Estrellas
5.4k
Forks
1.8k
Merge medio
2 d 23 h
PR fusionados (30 d)
123

Descripción

**Is your feature request related to a problem? Please describe.**
When using `Client.get_default_handler` `CloudLoggingHandler` is being used automatically for Cloud Run jobs resource. And while https://github.com/googleapis/python-logging/pull/877 fixes the missing labels we're still gonna be using background transport when simplier stdout is doing just fine.

**Describe the solution you'd like**
If we modify this check https://github.com/googleapis/python-logging/blob/62641075042a3da9bb9c059d963bad14a1586b1c/google/cloud/logging_v2/client.py#L388 and allow `_RUN_RESOURCE_TYPE` OR `_CLOUD_RUN_JOB_RESOURCE_TYPE` resource type then a structured log handler is gonna be used automatically which should be a better default.

**Describe alternatives you've considered**
Meanwhile I am using `handler = StructuredLogHandler(project_id=client.project)` instead of `handler = client.get_default_handler()` where client is `client = CloudLoggingClient()`

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.