googleapis / googleapis/google-cloud-python

Use shim for legacy client read_modify_write_row

Đang mở
#15,289 1 bình luận 0 reaction 1 người được giao Được @gkevinzheng nhận Xem trên GitHub
api: bigtable priority: p3 type: feature request
Ngôn ngữ chính
Python
Star
5.4k
Fork
1.8k
Merge trung bình
3 ngày 4 giờ
Pull request đã merge (30 ngày)
122

Mô tả

The legacy client implements read_modify_write_row in a custom [AppendRow class](https://github.com/googleapis/python-bigtable/blob/3648d7000df4a108524e29a9c55639dc92c1c2cc/google/cloud/bigtable/row.py#L777). Conditions are built up, and then the request is executed as part of the [commit()](https://github.com/googleapis/python-bigtable/blob/3648d7000df4a108524e29a9c55639dc92c1c2cc/google/cloud/bigtable/row.py#L897) call

The new data client tried to avoid the complexity of these custom Row types, and its API closely resembles the gapic call. We can likely simple swap out the legacy client's [gapic call](https://github.com/googleapis/python-bigtable/blob/3648d7000df4a108524e29a9c55639dc92c1c2cc/google/cloud/bigtable/row.py#L938) for the [veneer one](https://github.com/googleapis/python-bigtable/blob/3648d7000df4a108524e29a9c55639dc92c1c2cc/google/cloud/bigtable/data/_async/client.py#L1541), and remove the [redundant validation](https://github.com/googleapis/python-bigtable/blob/3648d7000df4a108524e29a9c55639dc92c1c2cc/google/cloud/bigtable/row.py#L928)

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.