googleapis / googleapis/google-cloud-python

Stripping "Z" from expiry date parsing in Credentials may lead to incorrect expires_at timestamp

Ouverte
#15,192 16 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
priority: p2 type: cleanup type: feature request
Langage dominant
Python
Étoiles
5.4k
Forks
1.8k
Merge moyen
3 j 4 h
PR mergées (30 j)
122

Description

#### Environment details

- OS: Mac OS 13.2.1
- Python version: 3.10.8
- pip version: 22.2.2
- `google-auth` version: 2.17.0

#### Steps to reproduce

1. Retrieve an initial access token via InstalledAppFlow with no TZ set and system time zone set to UTC-X (e.g. EDT)
2. Observe that expire_at is set beyond 1 hour (it should be returned with 1 hour + abs(time zone difference to UTC))
3. Refresh will not occur as expected and the access token expires

#### Notes

I believe the culprit may be [here](https://github.com/googleapis/google-auth-library-python/blob/main/google/oauth2/credentials.py#L398). The symptom investigations are [here](https://github.com/gilesknap/gphotos-sync/issues/413#issuecomment-1489341338).

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.