googleapis / googleapis/google-cloud-python

Stripping "Z" from expiry date parsing in Credentials may lead to incorrect expires_at timestamp

Abierto
#15,192 16 comentarios 0 reacciones 0 asignados Ver en GitHub
priority: p2 type: cleanup type: feature request
Lenguaje dominante
Python
Estrellas
5.4k
Forks
1.8k
Merge medio
3 d 4 h
PR fusionados (30 d)
122

Descripción

#### Environment details

- OS: Mac OS 13.2.1
- Python version: 3.10.8
- pip version: 22.2.2
- `google-auth` version: 2.17.0

#### Steps to reproduce

1. Retrieve an initial access token via InstalledAppFlow with no TZ set and system time zone set to UTC-X (e.g. EDT)
2. Observe that expire_at is set beyond 1 hour (it should be returned with 1 hour + abs(time zone difference to UTC))
3. Refresh will not occur as expected and the access token expires

#### Notes

I believe the culprit may be [here](https://github.com/googleapis/google-auth-library-python/blob/main/google/oauth2/credentials.py#L398). The symptom investigations are [here](https://github.com/gilesknap/gphotos-sync/issues/413#issuecomment-1489341338).

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.