googleapis / googleapis/google-cloud-java

Update Jitter in Exponential Retry Strategy

Aperta
#9,102 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
priority: p4 type: feature request
Lingua principale
Java
Stelle
2.1k
Fork
1.2k
Merge medio
1g 23h
PR unite (30g)
154

Descrizione

**Is your feature request related to a problem? Please describe.**
In Exponential Retry Strategy, Jitter is used to prevent from several clients retrying at the same time.
However, the [existing jitter](http://googleapis.github.io/gax-java/1.8.0/apidocs/com/google/api/gax/retrying/RetrySettings.Builder.html#setJittered-boolean-) value is generated per:

```
actualDelay = rand_between(0, min(maxRetryDelay, exponentialDelay))
```

The issue with the delay is with pathological case of a short delay, e.g. 1 second.

**Describe the solution you'd like**
It would help to update jitter delay to be either one of the following:

1. `actualDelay = exponentialDelay + rand_milliseconds()`
2. `actualDelay = rand_between(exponentialDelay - E, exponentialDelay + E)` where E is constant value used to create a range with respect to exponentialDelay.

**Describe alternatives you've considered**
Turning off jitter which defeats the purpose of having jitter.

First came up in: https://github.com/googleapis/java-storage/issues/178

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.